Re: [PATCH 01/23] staging/lustre/clio: don't ignore layout on writeback

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Jun 01, 2013 at 10:33:38AM +0800, Peng Tao wrote:
> On Sat, Jun 1, 2013 at 1:29 AM, Greg Kroah-Hartman
> <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> > On Sat, Jun 01, 2013 at 01:22:51AM +0800, Peng Tao wrote:
> >> From: Niu Yawei <yawei.niu@xxxxxxxxx>
> >>
> >> In some cases such as kernel writeback, we shouldn't ignore the
> >> layout, otherwise, it could race with layout change undergoing.
> >>
> >> Intel-bug-id: LU-3160
> >
> > What can I do with this number?
> >
> >> Lustre-commit: 3141db609d95d379761e3b54899618b4037d38f6
> >
> > Or this one?
> >
> >> Lustre-change: http://review.whamcloud.com/6154
> >
> > This one is at least informative, so it can stay, if you really want it
> > there, but the others are not relevant to anyone outside of your
> > internal development environment, so do not belong in a Linux kernel
> > commit message, sorry.
> >
> Hi Greg,
> 
> Thanks for the suggestions. But can we keep the "Intel-bug-id:" tag as well?
> Intel's bug tracking system is open for all to access at
> https://jira.hpdd.intel.com/browse/LU-nnnn (replace LU-nnnn with the
> specific bug ID).

As I never knew that, please just use the full bug url, like is done for
other distros.

> If you think "LU-nnnn" alone is less informative, how about expanding
> it to full URL? I can see that there are plenty of similar tags like
> "Bugzilla: URL" or "Redhat-Bugzilla: URL" in kernel commit log.

Yes, that is fine to do.

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux