On Fri, Nov 16, 2012 at 5:43 AM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > > Btw: >> + dev_dbg(&port->dev, "Line status status.\n"); > ^^^^^^^^^^^^^^^^^^^ > These kind of debug statements which just tell which function is > being called can be deleted. The function tracer already provides > that information. I did not know that. Thanks! >> + fn = ProcessLineStatus; >> + } else { >> + dev_dbg(&port->dev, "Modem status status.\n"); >> + fn = ProcessModemStatus; > > regards, > dan carpenter > -- Regards, YAMANE Toshiaki _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel