Re: [PATCH 2/4] staging/serqt_usb2: refactor qt_read_bulk_callback() in serqt_usb2.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Btw:
> +             dev_dbg(&port->dev, "Line status status.\n");
                                     ^^^^^^^^^^^^^^^^^^^
These kind of debug statements which just tell which function is
being called can be deleted.  The function tracer already provides
that information.

> +             fn = ProcessLineStatus;
> +     } else {
> +             dev_dbg(&port->dev, "Modem status status.\n");
> +             fn = ProcessModemStatus;

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux