Btw: > + dev_dbg(&port->dev, "Line status status.\n"); ^^^^^^^^^^^^^^^^^^^ These kind of debug statements which just tell which function is being called can be deleted. The function tracer already provides that information. > + fn = ProcessLineStatus; > + } else { > + dev_dbg(&port->dev, "Modem status status.\n"); > + fn = ProcessModemStatus; regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel