Re: [PATCH 1/4] staging: csr: fix the coding style problems

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 16 Aug 2012, Devendra Naga wrote:

> the following fixes:
> 
> 1. replace spaces with tabs
> 2. line over 80 characters
> 
> Signed-off-by: Devendra Naga <develkernel412222@xxxxxxxxx>
> ---
>  drivers/staging/csr/io.c |   34 ++++++++++++++++++----------------
>  1 files changed, 18 insertions(+), 16 deletions(-)
> 
> diff --git a/drivers/staging/csr/io.c b/drivers/staging/csr/io.c
> index deaff25..896ad99 100644
> --- a/drivers/staging/csr/io.c
> +++ b/drivers/staging/csr/io.c
> @@ -1115,14 +1115,14 @@ static CsrSdioFunctionId unifi_ids[] =
>   */
>  static CsrSdioFunctionDriver unifi_sdioFunction_drv =
>  {
> -    .inserted = uf_sdio_inserted,
> -    .removed = uf_sdio_removed,
> -    .intr = uf_sdio_int_handler,
> -    .suspend = uf_lx_suspend,
> -    .resume = uf_lx_resume,
> -
> -    .ids = unifi_ids,
> -    .idsCount = sizeof(unifi_ids) / sizeof(unifi_ids[0])
> +	.inserted = uf_sdio_inserted,
> +	.removed = uf_sdio_removed,
> +	.intr = uf_sdio_int_handler,
> +	.suspend = uf_lx_suspend,
> +	.resume = uf_lx_resume,
> +
> +	.ids = unifi_ids,
> +	.idsCount = sizeof(unifi_ids) / sizeof(unifi_ids[0])
>  };
>  
>  
> @@ -1145,15 +1145,17 @@ static CsrSdioFunctionDriver unifi_sdioFunction_drv =
>  int __init
>  uf_sdio_load(void)
>  {
> -    CsrResult csrResult;
> +	CsrResult csrResult;
>  
> -    csrResult = CsrSdioFunctionDriverRegister(&unifi_sdioFunction_drv);
> -    if (csrResult != CSR_RESULT_SUCCESS) {
> -        unifi_error(NULL, "Failed to register UniFi SDIO driver: csrResult=%d\n", csrResult);
> -        return -EIO;
> -    }
> +	csrResult = CsrSdioFunctionDriverRegister(&unifi_sdioFunction_drv);
> +	if (csrResult != CSR_RESULT_SUCCESS) {
> +		unifi_error(NULL,
> +			    "Failed to register UniFi SDIO driver:"
> +			    " csrResult=%d\n", csrResult);

The line may be more than 80 characters long, but even so you should not 
break user visible strings over multiple lines - that makes them harder to 
grep for.

             unifi_error(NULL,
                         "Failed to register UniFi SDIO driver: csrResult=%d\n",
                         csrResult);


> +		return -EIO;
> +	}
>  
> -    return 0;
> +	return 0;
>  } /* uf_sdio_load() */
>  
>  
> @@ -1161,6 +1163,6 @@ uf_sdio_load(void)
>  void __exit
>  uf_sdio_unload(void)
>  {
> -    CsrSdioFunctionDriverUnregister(&unifi_sdioFunction_drv);
> +	CsrSdioFunctionDriverUnregister(&unifi_sdioFunction_drv);
>  } /* uf_sdio_unload() */
>  
> 

-- 
Jesper Juhl <jj@xxxxxxxxxxxxx>       http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux