Re: [PATCH] staging: comedi: make attach handler optional

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Aug 15, 2012 at 01:00:15PM -0500, H Hartley Sweeten wrote:
> > @@ -885,13 +893,18 @@ static int comedi_auto_config_wrapper(struct comedi_device *dev, void *context)
> >  		dev->board_ptr = comedi_recognize(driv, it->board_name);
> >  		if (dev->board_ptr == NULL) {
> >  			printk(KERN_WARNING
> > -			       "comedi: auto config failed to find board entry"
> > -			       " '%s' for driver '%s'\n", it->board_name,
> > -			       driv->driver_name);
> > +			       "comedi: auto config failed to find board entry '%s' for driver '%s'\n",
> > +			       it->board_name, driv->driver_name);
> 
> Since your modifying this printk, it could (should) also be changed to a dev_warn().

I agree with this, and the other dev_warn() call, but I can take that as
a follow-on patch, so I'll take this one as-is.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux