[PATCH 4/4] staging: csr: remove unneeded goto in unifi_coredump_read_zone

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



this goto is at the end where we fail out reading the chip,
we compare against CSR_RESULT_SUCCESS, and fail out and return the error,
so using goto here is not needed.

Signed-off-by: Devendra Naga <develkernel412222@xxxxxxxxx>
---
 drivers/staging/csr/csr_wifi_hip_dump.c |    6 +-----
 1 files changed, 1 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/csr/csr_wifi_hip_dump.c b/drivers/staging/csr/csr_wifi_hip_dump.c
index ea5f14d..6381cb8 100644
--- a/drivers/staging/csr/csr_wifi_hip_dump.c
+++ b/drivers/staging/csr/csr_wifi_hip_dump.c
@@ -511,14 +511,10 @@ static CsrResult unifi_coredump_read_zone(card_t *card, u16 *zonebuf, const stru
     /* Read on-chip RAM (byte-wise) */
     r = unifi_card_readn(card, def->gp, zonebuf, (u16)(def->length * 2));
     if (r == CSR_WIFI_HIP_RESULT_NO_DEVICE)
-    {
         goto done;
-    }
+
     if (r != CSR_RESULT_SUCCESS)
-    {
         unifi_error(card->ospriv, "Can't read UniFi shared data area\n");
-        goto done;
-    }
 
 done:
     func_exit_r(r);
-- 
1.7.4.1

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux