On Wed, May 30, 2012 at 02:19:56PM +0100, Ian Abbott wrote: > Actually, if CONFIG_COMEDI_AMPLC_PC236_PCI isn't enabled, > pc236_boards[] is only one element long, so disregarding padding it > saves 2 bytes of data. As to your question, I guess no-one cares, > but as all the code that used it was #if'ed out I thought I might as > well #if out that structure member at the same time. > We hate hate hate ifdefs. What we should do is, we should have told Hartley to go ahead with his struct comedi_boardinfo idea. If this were in a .h file then it would be allowed to #ifdef out the devid. The more functions we could make general purpose the smaller the drivers would be probably. Or at least, the drivers would be simpler and easier to maintain which is the only thing we actually care about. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
