On Tue, May 29, 2012 at 02:49:35PM +0100, Ian Abbott wrote: > Implement the attach_pci() hook as function pc236_attach_pci(). This is > called bu comedi_pci_auto_config() in preference to the old attach() > hook (implemented by pc236_attach()) and avoids searching for the probed > PCI device. > > Factor out code common to pc236_find_pci() and pc236_attach_pci() into > new function pc236_find_pci_board(). Factor out most code common to > pc236_attach() and pc236_attach_pci() into new functions > pc236_pci_common_attach() and pc236_common_attach(). > > Also #if out member 'devid' from struct pc236_board unless PCI boards > are supported as it is not used for ISA boards. > I can't tell you how much I hate these ifdefs. :( They're every where... Who is it that cares about cares so much about 3 extra unsigned shorts? The rules are that #ifdefs are only ok in .h files and not in .c files. We should be removing them and not adding them if we want to move this code out of staging. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
