On Dec 2, 2011, at 3:40 PM, Dan Carpenter wrote: > It would be better to do a check for < 0 instead of -1 or even just > a check for non-zero. > > if (pdata->read_status(&status)) > return IRQ_NONE; > > That's more linux-ish. Sounds good to me. Will do a v3. Thanks. - xi _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel