Re: [PATCH v2] staging: olpc_dcon: ->read_status() API change

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Dec 2, 2011, at 3:40 PM, Dan Carpenter wrote:
> It would be better to do a check for < 0 instead of -1 or even just
> a check for non-zero.
> 
> 	if (pdata->read_status(&status))
> 		return IRQ_NONE;
> 
> That's more linux-ish.

Sounds good to me.  Will do a v3.  Thanks.

- xi
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux