Re: [PATCH] staging: olpc_dcon: signedness bug in dcon_interrupt()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Dec 1, 2011, at 7:04 PM, Andres Salomon wrote:
> Thanks for catching that.  I'd prefer to see this cleaned up, though.
> Error handling and the status bits (of which we only use two) should be
> separate.
> 
> ie, "int (*read_status)(u8 *status);"
> 
> Alternatively, we could have the high bit of that u8 mark an error,
> but I think using two variables is much easier to understand.

I like this API change.  Will do a new patch.

- xi
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux