Re: [PATCH] Staging: olpc_dcon.c: obsolete use of strict_strtoul

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Dec 02, 2011 at 04:23:01PM +0100, Valentin Rothberg wrote:
> @@ -501,7 +501,7 @@ static ssize_t dcon_resumeline_store(struct device *dev,
>  	unsigned long rl;
>  	int rc;
>  
> -	rc = strict_strtoul(buf, 10, &rl);
> +	rc = kstrtoul(buf, 10, &rl);
>  	if (rc)
>  		return rc;
>  

I feel like this should be u16, because dcon_write() will only write
a u16 value.  Also resumeline should be u16 as well.  The trick to
making that work is to declare it like this:

static ushort resumeline = 898;
module_param(resumeline, ushort, 0444);

(module_param() won't accept u16 as a valid data type.)

regards,
dan carpenter

Attachment: signature.asc
Description: Digital signature

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux