On Tue, Aug 18, 2020 at 04:58:53PM +0200, Mauro Carvalho Chehab wrote: > Both the SPMI controller and the SPMI PMIC driver > depends on the SPMI bus support. > > The dependency for the regulator is also wrong: > it should depends on the SPMI version of the HiSilicon 6421, > and not on the normal one. > > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx> > --- > drivers/staging/hikey9xx/Kconfig | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/hikey9xx/Kconfig b/drivers/staging/hikey9xx/Kconfig > index 76267b9be562..a004839e8fa9 100644 > --- a/drivers/staging/hikey9xx/Kconfig > +++ b/drivers/staging/hikey9xx/Kconfig > @@ -5,6 +5,7 @@ config SPMI_HISI3670 > tristate "Hisilicon 3670 SPMI Controller" > select IRQ_DOMAIN_HIERARCHY > depends on HAS_IOMEM > + depends on SPMI > help > If you say yes to this option, support will be included for the > built-in SPMI PMIC Arbiter interface on Hisilicon 3670 > @@ -14,6 +15,7 @@ config SPMI_HISI3670 > config MFD_HI6421_SPMI > tristate "HiSilicon Hi6421v600 SPMI PMU/Codec IC" > depends on OF > + depends on SPMI > select MFD_CORE > help > Add support for HiSilicon Hi6421v600 SPMI PMIC. Hi6421 includes > @@ -28,7 +30,7 @@ config MFD_HI6421_SPMI > # to be placed at drivers/regulator > config REGULATOR_HI6421V600 > tristate "HiSilicon Hi6421v600 PMIC voltage regulator support" > - depends on MFD_HI6421_PMIC && OF > + depends on MFD_HI6421_SPMI && OF > help > This driver provides support for the voltage regulators on > HiSilicon Hi6421v600 PMU / Codec IC. Better, but now I get the following build error: ERROR: modpost: "regulator_map_voltage_iterate" [drivers/staging/hikey9xx/hi6421v600-regulator.ko] undefined! ERROR: modpost: "regulator_list_voltage_table" [drivers/staging/hikey9xx/hi6421v600-regulator.ko] undefined! ERROR: modpost: "of_get_regulator_init_data" [drivers/staging/hikey9xx/hi6421v600-regulator.ko] undefined! ERROR: modpost: "regulator_register" [drivers/staging/hikey9xx/hi6421v600-regulator.ko] undefined! ERROR: modpost: "regulator_unregister" [drivers/staging/hikey9xx/hi6421v600-regulator.ko] undefined! ERROR: modpost: "rdev_get_drvdata" [drivers/staging/hikey9xx/hi6421v600-regulator.ko] undefined! Someone need CONFIG_REGULATOR enabled? Another follow-on patch? :) thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
