On Tue, Aug 18, 2020 at 07:29:02AM -0700, Randy Dunlap wrote: > On 8/18/20 6:49 AM, Alex Dewar wrote: > > Currently emxx_udc.h defines bit values using local macros. Use the > > standard one instead. > > > > Also, combine bit values with bitwise-or rather than addition, as > > suggested by Coccinelle. > > > > Signed-off-by: Alex Dewar <alex.dewar90@xxxxxxxxx> > > Hi, > > Does this build? Just checking. > > Looks like it would need this: > > #include <linux/bits.h> > > since it (indirectly) provides definition of the BIT() macro. Yeah, it builds, because emxx_udc.c includes emxx_udc.h after a bunch of standard headers. I agree that it would probably be cleaner to have the include in there explicitly, though. Best, Alex > > > --- > > drivers/staging/emxx_udc/emxx_udc.h | 456 +++++++++++++--------------- > > 1 file changed, 211 insertions(+), 245 deletions(-) > > > thanks. > -- > ~Randy > _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
