On 5/04/19 3:12 PM, Stefan Wahren wrote:
Hi Jasminko,
Am 24.03.19 um 18:17 schrieb Jasminko Dedic:
This patch fixes the following sparse warnings by adding missing __user
annotations. It also cleans up two related unnecessary casts by reuseing
casts already made a few lines up. Remaining sparse warnings are of a
different type.
vchiq_arm.c:1606:14: warning: incorrect type in assignment (different address spaces)
vchiq_arm.c:1606:14: expected struct vchiq_queue_message *args
vchiq_arm.c:1606:14: got void [noderef] <asn:1> *
vchiq_arm.c:1612:13: warning: incorrect type in argument 1 (different address spaces)
vchiq_arm.c:1612:13: expected void const volatile [noderef] <asn:1> *
vchiq_arm.c:1612:13: got unsigned int *
vchiq_arm.c:1613:13: warning: incorrect type in argument 1 (different address spaces)
vchiq_arm.c:1613:13: expected void const volatile [noderef] <asn:1> *
vchiq_arm.c:1613:13: got unsigned int *
vchiq_arm.c:1614:13: warning: incorrect type in argument 1 (different address spaces)
vchiq_arm.c:1614:13: expected void const volatile [noderef] <asn:1> *
vchiq_arm.c:1614:13: got struct vchiq_element const [noderef] <asn:1> **
vchiq_arm.c:1638:21: warning: incorrect type in argument 1 (different address spaces)
vchiq_arm.c:1638:21: expected void const volatile [noderef] <asn:1> *
vchiq_arm.c:1638:21: got struct vchiq_element const [noderef] <asn:1> **
Signed-off-by: Jasminko Dedic <betelge@xxxxxxxxx>
maybe this sounds overcautious to you, but did you test your patch on a
Raspberry Pi?
Hello,
I've tested it on a Raspberry Pi 3 b, with a 32 bit linux-next kernel,
and with an aarch64 rpi-5.0.y kernel, without any issues.
I was not able to boot any arch64 linux-next kernel on the Raspberry Pi,
and I'm not sure why. I tried mainline u-boot and without u-boot. If
anyone has any tips for how to do that, I can test the patch with an
aarch64 linux-next kernel too.
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
