Re: [PATCH] staging: vc04_services: add missing __user annotations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jasminko,

Am 24.03.19 um 18:17 schrieb Jasminko Dedic:
> This patch fixes the following sparse warnings by adding missing __user
> annotations. It also cleans up two related unnecessary casts by reuseing
> casts already made a few lines up. Remaining sparse warnings are of a
> different type.
>
> vchiq_arm.c:1606:14: warning: incorrect type in assignment (different address spaces)
> vchiq_arm.c:1606:14:    expected struct vchiq_queue_message *args
> vchiq_arm.c:1606:14:    got void [noderef] <asn:1> *
>
> vchiq_arm.c:1612:13: warning: incorrect type in argument 1 (different address spaces)
> vchiq_arm.c:1612:13:    expected void const volatile [noderef] <asn:1> *
> vchiq_arm.c:1612:13:    got unsigned int *
>
> vchiq_arm.c:1613:13: warning: incorrect type in argument 1 (different address spaces)
> vchiq_arm.c:1613:13:    expected void const volatile [noderef] <asn:1> *
> vchiq_arm.c:1613:13:    got unsigned int *
>
> vchiq_arm.c:1614:13: warning: incorrect type in argument 1 (different address spaces)
> vchiq_arm.c:1614:13:    expected void const volatile [noderef] <asn:1> *
> vchiq_arm.c:1614:13:    got struct vchiq_element const [noderef] <asn:1> **
>
> vchiq_arm.c:1638:21: warning: incorrect type in argument 1 (different address spaces)
> vchiq_arm.c:1638:21:    expected void const volatile [noderef] <asn:1> *
> vchiq_arm.c:1638:21:    got struct vchiq_element const [noderef] <asn:1> **
>
> Signed-off-by: Jasminko Dedic <betelge@xxxxxxxxx>
maybe this sounds overcautious to you, but did you test your patch on a
Raspberry Pi?
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux