Re: [PATCH 2/8] staging: brcm80211: cleanup mac80211 callback bss_info_changed

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Feb 10, 2011 at 12:43:34AM +0300, Dan Carpenter wrote:
> On Wed, Feb 09, 2011 at 10:11:03PM +0100, Arend van Spriel wrote:
> > On Wed, 09 Feb 2011 20:45:12 +0100, Greg KH <greg@xxxxxxxxx> wrote:
> > 
> > >On Wed, Feb 09, 2011 at 12:16:26AM +0300, Dan Carpenter wrote:
> > >>On Tue, Feb 08, 2011 at 02:39:14PM +0100, Arend van Spriel wrote:
> > >>> The implementation for bss_info_changed was not handling all
> > >>> changes as provided by mac80211 module. These have been added
> > >>> where needed.
> > >>>
> > >>
> > >>The subject says clean up and the long description say implementing
> > >>new features were implemented on an as needed basis.
> > >>
> > 
> > Your remark applies to the cover letter describing the patch series.
> > Each individual patch in this series is targetting a separate issue
> > imho.
> > 
> 
> No, I mean this patch specifically.  Git history doesn't care about
> patch sets, only about individual patches.  (The cover letter is not
> saved anywhere).  I've commented on the patch below which I things I
> view as behavior changes and which I view as cleanup.

Arend, I agree with Dan here, please rework the patch series you just
resent to not do stuff like this.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux