Re: [PATCH 2/8] staging: brcm80211: cleanup mac80211 callback bss_info_changed

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Feb 09, 2011 at 12:16:26AM +0300, Dan Carpenter wrote:
> On Tue, Feb 08, 2011 at 02:39:14PM +0100, Arend van Spriel wrote:
> > The implementation for bss_info_changed was not handling all
> > changes as provided by mac80211 module. These have been added
> > where needed.
> > 
> 
> The subject says clean up and the long description say implementing
> new features were implemented on an as needed basis.
> 
> 1)  Please try to keep things separate.
> 2)  "Features which are needed" is not a very specific description.

I'll second this, please, in the future, be more specific, and do NOT
mix things in a patch.

Remember, do ONE thing per patch.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux