On Wed, 09 Feb 2011 20:45:12 +0100, Greg KH <greg@xxxxxxxxx> wrote:
On Wed, Feb 09, 2011 at 12:16:26AM +0300, Dan Carpenter wrote:
On Tue, Feb 08, 2011 at 02:39:14PM +0100, Arend van Spriel wrote:
> The implementation for bss_info_changed was not handling all
> changes as provided by mac80211 module. These have been added
> where needed.
>
The subject says clean up and the long description say implementing
new features were implemented on an as needed basis.
Your remark applies to the cover letter describing the patch series.
Each individual patch in this series is targetting a separate issue
imho.
1) Please try to keep things separate.
2) "Features which are needed" is not a very specific description.
I'll second this, please, in the future, be more specific, and do NOT
mix things in a patch.
Remember, do ONE thing per patch.
I believe I did.
thanks,
greg k-h
Gr. AvS
--
"The most merciful thing in the world, I think, is the inability of the
human
mind to correlate all its contents." - "The Call of Cthulhu"
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel