> -----Original Message----- > From: Greg KH [mailto:gregkh@xxxxxxx] > Sent: Wednesday, February 09, 2011 7:11 AM > To: Winkler, Tomas > Cc: Dan Carpenter; devel@xxxxxxxxxxxxxxxxxxxxxx; Mike Thomas > Subject: Re: [staging-next 02/12] staging/easycap: prefer printk over SAY in > module entry functions > > On Wed, Feb 09, 2011 at 07:03:22AM +0200, Winkler, Tomas wrote: > > > > > -----Original Message----- > > > From: Dan Carpenter [mailto:error27@xxxxxxxxx] > > > Sent: Wednesday, February 09, 2011 1:34 AM > > > To: Winkler, Tomas > > > Cc: gregkh@xxxxxxx; devel@xxxxxxxxxxxxxxxxxxxxxx; Mike Thomas > > > Subject: Re: [staging-next 02/12] staging/easycap: prefer printk over > SAY in > > > module entry functions > > > > > > On Wed, Feb 09, 2011 at 01:12:41AM +0200, Tomas Winkler wrote: > > > > + printk(KERN_INFO "Easycap version: "EASYCAP_DRIVER_VERSION > "\n"); > > > > + > > > > > > These should just be deleted. The user can use `modinfo` if they care. > > > > It is very common and I think also good practices to notify user when a > driver is loaded. > > No, not at all. Do you really want to see this for EVERY driver your > system loads? > > We are removing these slowly, as it makes no sense at all. Please don't > add to it. Distros patch this kind of thing away to make for faster > boot time and cleaner load times, don't add extra work. Fast boot is a good reason. I will rework the patch Tomas --------------------------------------------------------------------- Intel Israel (74) Limited This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
