> -----Original Message----- > From: Dan Carpenter [mailto:error27@xxxxxxxxx] > Sent: Wednesday, February 09, 2011 1:34 AM > To: Winkler, Tomas > Cc: gregkh@xxxxxxx; devel@xxxxxxxxxxxxxxxxxxxxxx; Mike Thomas > Subject: Re: [staging-next 02/12] staging/easycap: prefer printk over SAY in > module entry functions > > On Wed, Feb 09, 2011 at 01:12:41AM +0200, Tomas Winkler wrote: > > + printk(KERN_INFO "Easycap version: "EASYCAP_DRIVER_VERSION "\n"); > > + > > These should just be deleted. The user can use `modinfo` if they care. It is very common and I think also good practices to notify user when a driver is loaded. Very rough estimation: find linux-2.6 -name "*.c" | xargs grep __init -A 10 | grep KERN_INFO | wc -l 970 --------------------------------------------------------------------- Intel Israel (74) Limited This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
