Re: [staging-next 11/12] staging/easycap: use regget for register back reading

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Feb 09, 2011 at 01:12:50AM +0200, Tomas Winkler wrote:
> +	rc1 = regget(pusb_device, index, &igot, sizeof(igot));

You didn't introduce this either but &igot is a stack address and it's
a bug on some arches to use stack addresses for DMA.  This is documented
in Documentation/DMA-API-HOWTO.txt

It seems like it should be documented with usb_control_msg() though if
it were actually an issue, so perhaps I'm wrong on this point.

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux