> -----Original Message----- > From: Dan Carpenter [mailto:error27@xxxxxxxxx] > Sent: Wednesday, February 09, 2011 1:48 AM > To: Winkler, Tomas > Cc: gregkh@xxxxxxx; devel@xxxxxxxxxxxxxxxxxxxxxx; Mike Thomas > Subject: Re: [staging-next 09/12] staging/eascap: add first level > indentation to regget/set functions > > On Wed, Feb 09, 2011 at 01:12:48AM +0200, Tomas Winkler wrote: > > + > > + return 0xFF & rc; > > You didn't introduce this, but it's wrong. It's masking out negative > error codes. The caller does check for error codes. Probably it > would make more sense to just return rc directly... I'm not sure what > was intended here. You have a point although in this particular case it is more pointless then wrong. I will fix in another patch, though. Tomas \ --------------------------------------------------------------------- Intel Israel (74) Limited This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
