On Tue, Oct 19, 2010 at 06:03:20PM -0700, Greg KH wrote: > On Tue, Oct 19, 2010 at 05:55:46PM -0700, Henry Ptasinski wrote: > > On Tue, Oct 19, 2010 at 05:47:43PM -0700, Greg KH wrote: > > > On Tue, Oct 19, 2010 at 04:45:26PM -0700, Nohee Ko wrote: > > > > >> > > > > Have you made the same changes in the linux-firmware source tree as > > > > well? Without changing it there, this could get messy. > > > > << > > > > > > > > No not yet. But we are planning sooner or later. > > > > > > Please do it sooner. > > > > > > I'll wait for that to happen before committing this patch. > > > > There's no specific changes needed in the linux-firmware repo to work with this > > driver change. There is a bugfix version of the firmware that we're getting > > ready to send up, which is the motivation for this change, but the change > > will work properly with the firmware that's in the repo today. > > How, you just renamed the file you look for in the driver, right? > > > All this change does is replace the hard-coded full firmware filename used in > > the driver with the basename-apiversion construction as documented in > > > > http://www.linuxwireless.org/en/developers/Documentation/firmware-versioning > > > > plus add some info to the README to help users get the firmware properly > > installed. > > > > Users will need to create the symlinks as described in the README to use these > > driver changes. > > Yes, so you just broke their working setup, right? > > So, please get linux-firmware fixed to add the proper symlinks, and then > I can apply the patch, and say "go upgrade your linux-firmware package", > which is almost acceptable. Ah, I didn't catch that the symlink should be in the linux-firmware repo. We didn't do that for the brcm80211 driver firmware either, and nobody pointed it out. But I don't see any symlinks in the linux-firmware repo. Is anybody else using the "best practices" as documented? Or should we just punt the codeversion part of the filenames and the symlinks, and just use basename-apiversion? Thanks, - Henry _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
