> -----Original Message----- > From: Andrew Morton [mailto:akpm@xxxxxxxxxxxxxxxxxxxx] > Sent: Wednesday, October 20, 2010 12:22 AM > To: Savoy, Pavan > Cc: gregkh@xxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; alan@xxxxxxxxxxxxxxxxxxx; > devel@xxxxxxxxxxxxxxxxxxxx > Subject: Re: [PATCH 1/2] drivers:staging:ti-st: move TI_ST from staging > > On Wed, 6 Oct 2010 12:18:14 -0400 pavan_savoy@xxxxxx wrote: > > > +/** > > + * st_reg_complete - > > + * to call registration complete callbacks > > + * of all protocol stack drivers > > + */ > > +void st_reg_complete(struct st_data_s *st_gdata, char err) > > The driver has a lot of "kerneldoc" comments which are incomplete - > they don't document the arguments. For functions too? Sure Andrew, I will post a patch to comment the arguments soon. Thanks for the comments. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel