> Subject: Re: [PATCH net-next v2 1/8] net: phylink: propagate resolved link config > via mac_link_up() > > On Wed, 26 Feb 2020 at 20:21, Vladimir Oltean <olteanv@xxxxxxxxx> wrote: > > > > On Wed, 26 Feb 2020 at 15:36, Russell King - ARM Linux admin > > <linux@xxxxxxxxxxxxxxx> wrote: > > > > > > > > > dpaa2 is complicated by the firmware, and that we can't switch the > > > interface mode between (SGMII,1000base-X) and 10G. > > > > > > If the firmware is in "DPMAC_LINK_TYPE_PHY" mode, it expects to be > > > told the current link parameters via the dpmac_set_link_state() call > > > - it isn't clear whether that needs to be called for other modes > > > with the up/down state (firmware API documentation is poor.) > > > > > > > With PCS control in Linux, I am pretty sure that you don't want > > anything other than DPMAC_LINK_TYPE_PHY anyway. > > Basically in DPMAC_LINK_TYPE_FIXED, the MC firmware is in control of > > the PCS and polls its link state to emit link notifications to objects > > connected to the DPMAC. So Linux control of PCS would class with > > s/class/clash/ > > > firmware control of the PCS, leading to undesirable side-effects to > > say the least. If the DPMAC object is in DPMAC_LINK_TYPE_FIXED, the dpaa2-eth in fact does not even connect to a phy so all the phylink interaction is not happening. As Vladimir said, in this case it's the MC firmware's job to poll the PCS and notify any connected objects of a link change. > > > > Regards, > > -Vladimir
