On Sun, Mar 3, 2019 at 12:10 PM Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > > On Sun, Mar 03, 2019 at 12:36:47PM +0000, Louis Taylor wrote: > > A few commonly used integer types were absent from this table, so add > > them. > > I'm not against the patch, but isn't obvious by reading POSIX and / or man > printf(3)? You'd think; but based on the sheer number of -Wformat warnings (~450), I'm not so sure. At least with this patch they're "above the fold." The kernel also has its own format flag extensions, and does not implement %n (for good reason), so it's better to be explicit than imply posix or glibc compat. -- Thanks, ~Nick Desaulniers
