On Mon, Mar 4, 2019 at 7:45 AM Petr Mladek <pmladek@xxxxxxxx> wrote: > > On Sun 2019-03-03 12:36:47, Louis Taylor wrote: > > A few commonly used integer types were absent from this table, so add > > them. > > > > Link: https://github.com/ClangBuiltLinux/linux/issues/378 > > Suggested-by: Nick Desaulniers <ndesaulniers@xxxxxxxxxx> > > Signed-off-by: Louis Taylor <louis@xxxxxxxxxx> > > --- > > Documentation/core-api/printk-formats.rst | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/Documentation/core-api/printk-formats.rst b/Documentation/core-api/printk-formats.rst > > index a7fae4538946..6f08b1b6240a 100644 > > --- a/Documentation/core-api/printk-formats.rst > > +++ b/Documentation/core-api/printk-formats.rst > > @@ -19,8 +19,16 @@ Integer types > > unsigned long %lu or %lx > > long long %lld or %llx > > unsigned long long %llu or %llx > > + short int %hd or %hx > > + unsigned short int %hu or %hx > > + char %hhd or %hhx > > + unsigned char %hhu or %hhx > > These should get moved to the beginning of the table to > have all variants sorted by size. > > > size_t %zu or %zx > > ssize_t %zd or %zx > > + s8 %hhd or %hhx > > + u8 %hhu or %hhx > > + s16 %hd or %hx > > + u16 %hu or %hx > > s32 %d or %x > > u32 %u or %x > > s64 %lld or %llx > > Let's get it in when people are doing the clean up. > > I have fixed the sorting and committed into printk.git, > branch for-5.1, see > https://git.kernel.org/pub/scm/linux/kernel/git/pmladek/printk.git/commit/?h=for-5.1&id=943ca6ad81e5b37bd5d22cbab5ad06dc97fc001c Sure that's fine. Thanks for keeping Louis as the author, and for the clean up. Reviewed-by: Nick Desaulniers <ndesaulniers@xxxxxxxxxx> -- Thanks, ~Nick Desaulniers