Hi Krzysztof, Thanks for the comments. On 11/12/18 9:51 AM, Krzysztof Kozlowski wrote: > On Wed, 7 Nov 2018 at 18:10, Lukasz Luba <l.luba@xxxxxxxxxxxxxxxxxxx> wrote: >> > > Subject prefix: > dt-bindings: thermal: > >> Thermal trip point gets new flag in DT: irq-mode. >> Trip point may have a new explicit flag which indicate >> IRQ support when the temperature is met (so the thermal framework >> deos not need to set polling for it). >> It is useful for 'passive' cooling trip point, >> which now will not register for polling the temperature. > > You wrap lines in weird way making it more difficult to read. > I already asked about this while reviewing v1. Please fix it. > https://elixir.bootlin.com/linux/latest/source/Documentation/process/submitting-patches.rst#L633 > I will fix it in v3. >> >> Update documentation about irq-mode for trip points. >> >> Cc: Zhang Rui <rui.zhang@xxxxxxxxx> >> Cc: Eduardo Valentin <edubezval@xxxxxxxxx> >> Cc: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx> >> Cc: Rob Herring <robh+dt@xxxxxxxxxx> >> Cc: Mark Rutland <mark.rutland@xxxxxxx> >> Cc: devicetree@xxxxxxxxxxxxxxx >> Signed-off-by: Lukasz Luba <l.luba@xxxxxxxxxxxxxxxxxxx> >> --- >> Documentation/devicetree/bindings/thermal/thermal.txt | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/thermal/thermal.txt b/Documentation/devicetree/bindings/thermal/thermal.txt >> index ca14ba9..bee21e3 100644 >> --- a/Documentation/devicetree/bindings/thermal/thermal.txt >> +++ b/Documentation/devicetree/bindings/thermal/thermal.txt >> @@ -90,6 +90,10 @@ Required properties: >> "critical": Hardware not reliable. >> Type: string >> >> +- irq-mode: A flag indicating that trip rises irq, so there is no > > "rises IRQ" (it is an abbreviation). ACK > > Best regards, > Krzysztof > Regards, Lukasz
