On Wed, 7 Nov 2018 at 18:10, Lukasz Luba <l.luba@xxxxxxxxxxxxxxxxxxx> wrote: > Subject prefix: dt-bindings: thermal: > Thermal trip point gets new flag in DT: irq-mode. > Trip point may have a new explicit flag which indicate > IRQ support when the temperature is met (so the thermal framework > deos not need to set polling for it). > It is useful for 'passive' cooling trip point, > which now will not register for polling the temperature. You wrap lines in weird way making it more difficult to read. I already asked about this while reviewing v1. Please fix it. https://elixir.bootlin.com/linux/latest/source/Documentation/process/submitting-patches.rst#L633 > > Update documentation about irq-mode for trip points. > > Cc: Zhang Rui <rui.zhang@xxxxxxxxx> > Cc: Eduardo Valentin <edubezval@xxxxxxxxx> > Cc: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx> > Cc: Rob Herring <robh+dt@xxxxxxxxxx> > Cc: Mark Rutland <mark.rutland@xxxxxxx> > Cc: devicetree@xxxxxxxxxxxxxxx > Signed-off-by: Lukasz Luba <l.luba@xxxxxxxxxxxxxxxxxxx> > --- > Documentation/devicetree/bindings/thermal/thermal.txt | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/thermal/thermal.txt b/Documentation/devicetree/bindings/thermal/thermal.txt > index ca14ba9..bee21e3 100644 > --- a/Documentation/devicetree/bindings/thermal/thermal.txt > +++ b/Documentation/devicetree/bindings/thermal/thermal.txt > @@ -90,6 +90,10 @@ Required properties: > "critical": Hardware not reliable. > Type: string > > +- irq-mode: A flag indicating that trip rises irq, so there is no "rises IRQ" (it is an abbreviation). Best regards, Krzysztof > + Type: bool need of polling in thermal framework. > + Size: one cell > + > * Cooling device maps > > The cooling device maps node is a node to describe how cooling devices > @@ -256,16 +260,19 @@ thermal-zones { > temperature = <90000>; /* millicelsius */ > hysteresis = <2000>; /* millicelsius */ > type = "active"; > + irq-mode; > }; > cpu_alert1: cpu-alert1 { > temperature = <100000>; /* millicelsius */ > hysteresis = <2000>; /* millicelsius */ > type = "passive"; > + irq-mode; > }; > cpu_crit: cpu-crit { > temperature = <125000>; /* millicelsius */ > hysteresis = <2000>; /* millicelsius */ > type = "critical"; > + irq-mode; > }; > }; > > -- > 2.7.4 >
