On Wed, Oct 23, 2013 at 02:35:23PM +0800, Shawn Guo wrote: > > > > +static void mxs_phy_disconnect_line(struct mxs_phy *mxs_phy, bool on) > > +{ > > + void __iomem *base = mxs_phy->phy.io_priv; > > + bool vbus_is_on = false; > > + static bool line_is_disconnected; > > + unsigned int vbus_value = 0; > > + > > + /* Only the SoCs have anatop need below operation */ > > + if (!mxs_phy->disconnect_line_without_vbus_is_needed) > > + return; > > As per the comment, shouldn't the if-clause be the following? Or is the > comment incorrect? > > if (!mxs_phy->regmap_anatop) > > Shawn > Thanks, I will change the comment to /* If the SoC doesn't need to disconnect line without vbus, quit */ -- Best Regards, Peter Chen -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html