On Thu, Jan 25, 2024 at 12:34:24AM +0100, Borislav Petkov wrote:
> On Wed, Jan 24, 2024 at 03:03:15PM -0800, Reinette Chatre wrote:
> > Since you are the one that decides the rules for inclusion you can make this
> > check to be one where checkpatch.pl can be ignored. No objection from me if
> > you choose to do so (and I will note the precedent for future patches).
>
> Nah, that's not nearly as important for you to change your workflow.
>
> What I'd suggest, though, is to sanity-check what checkpatch suggests and
> ask yourself whether it always makes sense.
Dammit, there's a reason I don't use this abomination:
$ cat /tmp/0001-x86-resctrl-Remove-redundant-variable-in-mbm_config_.patch | ./scripts/checkpatch.pl
WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#9:
commit 54e35eb8611c ("x86/resctrl: Read supported bandwidth sources from CPUID").
WTF?!
I have a line underneath which is even one char longer:
" commit 92bd5a139033 ("x86/resctrl: Add interface to write mbm_total_bytes_config")"
but it doesn't complain about it.
What a bunch of crap.
I'm writing it as a maximally readable commit message and that's it.
Human-readable beats any script, any day of the week.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
