Hi,
On Wed, Jan 24, 2024 at 12:04:31PM -0800, Reinette Chatre wrote:
> > 54e35eb8611c ("x86/resctrl: Read supported bandwidth sources from CPUID").
>
> I think a "commit" prefix is required here and below.
Yeah, but if you see a 12-char sha1 followed by a title in (" "), that
is a commit and nothing else, right?
If I say "commit" too it is kinda redundant.
> > Fixes: 92bd5a139033 ("x86/resctrl: Add interface to write mbm_total_bytes_config")
> > Closes: https://lore.kernel.org/oe-kbuild-all/202401241810.jbd8Ipa1-lkp@xxxxxxxxx/
> > Reported-by: kernel test robot <lkp@xxxxxxxxx>
>
> I do not know if this is something tip prefers but the general patch checkers prefer
> that "Reported-by:" is followed by "Closes:".
Good question. Documentation/process/maintainer-tip.rst doesn't clarify
that, lemme send a patch for it and see what my brethren in arms think.
:-)
> This shifts the alignment slightly to no longer match the open parenthesis.
Fixed.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
