Hi Andrew, On 31/10/23 6:23 pm, Andrew Lunn wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > >> Ah ok, then it is supposed to be like below, isn't it? >> >> static int lan865x_set_mac_address(struct net_device *netdev, void *addr) >> { >> struct sockaddr *address = addr; >> int ret; >> >> if (netif_running(netdev)) >> return -EBUSY; >> >> ret = lan865x_set_hw_macaddr(netdev); >> if (ret) >> return ret; >> >> eth_hw_addr_set(netdev, address->sa_data); >> >> return 0; >> } > > Yes, that is better. In practice, its probably not an issue, setting > the MAC address will never fail, but it is good to get right, just in > case. Ok, thanks. Best Regards, Parthiban V > > Andrew