Hi Andrew, On 31/10/23 6:18 pm, Andrew Lunn wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > >>>> + tc6->mdiobus = mdiobus_alloc(); >>>> + if (!tc6->mdiobus) { >>>> + netdev_err(tc6->netdev, "MDIO bus alloc failed\n"); >>>> + return -ENODEV; >>>> + } >>>> + >>>> + tc6->mdiobus->phy_mask = ~(u32)BIT(1); >>> >>> Does the standard define this ? BIT(1), not BIT(0)? >> Ok, I think here is a typo. Will correct it. > > There is still the open question, does the standard define this? If > not, a vendor might decide to use some other address, not 0. So it > might be better to not set a mask and scan the whole bus. > phy_find_first() should then work, no matter what address it is using. The standard doesn't define anything about this. Ok I agree with this, and remove the phy_mask and leave the phy_find_first() to find the phy. Best Regards, Parthiban V > > Andrew