Re: [PATCH 1/2] gpio: mcp23s08: rename the device tree property

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Friday 23 August 2013 at 16:24:21, Mark Rutland wrote:
> On Thu, Aug 22, 2013 at 10:56:17AM +0100, Lars Poeschel wrote:
> > From: Lars Poeschel <poeschel@xxxxxxxxxxx>
> > 
> > The device tree property should be more descriptive.
> > microchip seems more reasonable than mcp. As there are no
> > in tree users of this property, so the rename can still be
> > done without pain.
> 
> Are there definitely no users? I see there are no dts with a
> "mcp,mcp23***" compatible string, but are there any boards already out
> there with this hardware that someone might be using and a currently
> release kernel supports?

What do you mean by "release"? The device tree support for the gpio-
mcp23s08 driver and thus the "mcp" string came in with v3.9. This is stable 
but not longterm.

> With the bcm/broadcom => brcm change, we marked the old vendor prefix as
> deprecated (but left the support code).
> 
> If we can 100% guarantee no-one's using the compatible string, I'm happy
> to change it. Otherwise we just have to mark the old string as
> deprecated.

I am the developer of the device tree support for that driver and I am not 
aware of any user, but surely I can not guarantee it.

I never imagined how hard it would be. ;-)
I presented both variants:
1.) simply add mcp to vendor-prefixes.txt
2.) change the driver to microchip and add microchip to vendor-prefixes.txt

May one of the maintainers decide which one to take or even take none of 
the patches.
Or do you need a third variant with both strings in the driver and 
microchip in vendor-prefixes?

Lars
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux