On Fri, May 26, 2023 at 11:58 AM Vineeth Remanan Pillai <vineeth@xxxxxxxxxxxxxxx> wrote: > > > > ...But I think this is wrong (should be "Umax - ...", not "1 - ..."). > > > I think patch 2/2 has the same issue. > > > > > Oops sorry, I missed this. Will send the fixed patch as a > > reply to the original v4. > > > On looking again, I think the description is correct. That line > mentions the actual m-GRUB equation from the paper. And then the > comment explains why we use Umax(because of limiting the bandwidth > to RT capacity). > Ahh my bad again :-(, I was looking at the commit message. I see the issue in the code comment now. I have just sent the fix as a reply to the initial patch. I shall send a v5 if needed. Please let me know. Thanks, Vineeth
