Hi Luca, > > On Fri, May 26, 2023 at 11:30 AM luca abeni <luca.abeni@xxxxxxxxxxxxxxx> wrote: > > [...] > > > + * but as "dq = -(max{u, (1 - Uinact - Uextra)} / Umax) dt", > > > > ...But I think this is wrong (should be "Umax - ...", not "1 - ..."). > > I think patch 2/2 has the same issue. > > > Oops sorry, I missed this. Will send the fixed patch as a > reply to the original v4. > On looking again, I think the description is correct. That line mentions the actual m-GRUB equation from the paper. And then the comment explains why we use Umax(because of limiting the bandwidth to RT capacity). Does it seem correct to you? Thanks, Vineeth