On Thu, Sep 08, 2022 at 10:34:07AM -0700, matthew.gerlach@xxxxxxxxxxxxxxx wrote: > On Thu, 8 Sep 2022, Andy Shevchenko wrote: > > On Wed, Sep 07, 2022 at 02:37:32PM -0700, matthew.gerlach@xxxxxxxxxxxxxxx wrote: ... > > This one tends to be expanded in the future, so I would keep it switch case. > > I'm okay with using the switch statement, but how about the following? > > switch (FIELD_GET(DFH_VERSION, readq(base))) { > case 1: > ... > break; > } Fine to me. -- With Best Regards, Andy Shevchenko