Hi Grant, > -----Original Message----- > From: Grant Likely [mailto:glikely@xxxxxxxxxxxx] On Behalf Of Grant > Likely > Sent: Thursday, June 06, 2013 5:32 AM > To: J, KEERTHY; linux-kernel@xxxxxxxxxxxxxxx > Cc: linux-doc@xxxxxxxxxxxxxxx; devicetree-discuss@xxxxxxxxxxxxxxxx; > swarren@xxxxxxxxxxxxx; broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx; > rob.herring@xxxxxxxxxxx; rob@xxxxxxxxxxx; sameo@xxxxxxxxxxxxxxx; > wim@xxxxxxxxx; lgirdwood@xxxxxxxxx; gg@xxxxxxxxxxxxxxx; Kristo, Tero; > lee.jones@xxxxxxxxxx; J, KEERTHY; Ian Lartey > Subject: Re: [PATCH v2] mfd: DT bindings for the palmas family MFD > > On Tue, 4 Jun 2013 14:11:49 +0530, J Keerthy <j-keerthy@xxxxxx> wrote: > > From: Graeme Gregory <gg@xxxxxxxxxxxxxxx> > > > > Add the various binding files for the palmas family of chips. There > is > > a top level MFD binding then a seperate binding for regulators IP > blocks on chips. > > > > Signed-off-by: Graeme Gregory <gg@xxxxxxxxxxxxxxx> > > Signed-off-by: J Keerthy <j-keerthy@xxxxxx> > > Signed-off-by: Ian Lartey <ian@xxxxxxxxxxxxxxx> > > Applied, thanks. > There are couple of minor comments from Stephen. I will post a v3 Of this with an Acked-by: Stephen. Could you please pull that And drop this? > g. > Regards, Keerthy > > --- > > Changes from v1: > > * Corrected ti,ldo6_vibrator property ---> ti,ldo6-vibrator > > * Added the irq.h header file inclusion for defining type of > interrupt > > > > Documentation/devicetree/bindings/mfd/palmas.txt | 49 > +++++++++++++++ > > .../devicetree/bindings/regulator/palmas-pmic.txt | 65 > ++++++++++++++++++++ > > 2 files changed, 114 insertions(+), 0 deletions(-) create mode > > 100644 Documentation/devicetree/bindings/mfd/palmas.txt > > create mode 100644 > > Documentation/devicetree/bindings/regulator/palmas-pmic.txt > > > > diff --git a/Documentation/devicetree/bindings/mfd/palmas.txt > > b/Documentation/devicetree/bindings/mfd/palmas.txt > > new file mode 100644 > > index 0000000..c6c5e78 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/mfd/palmas.txt > > @@ -0,0 +1,49 @@ > > +* palmas device tree bindings > > + > > +The TI palmas family current members :- > > +twl6035 (palmas) > > +twl6037 (palmas) > > +tps65913 (palmas) > > +tps65914 (palmas) > > + > > +Required properties: > > +- compatible : Should be from the list > > + ti,twl6035 > > + ti,twl6036 > > + ti,twl6037 > > + ti,tps65913 > > + ti,tps65914 > > + ti,tps80036 > > +and also the generic series names > > + ti,palmas > > +- interrupt-controller : palmas has its own internal IRQs > > +- #interrupt-cells : should be set to 2 for IRQ number and flags > > + The first cell is the IRQ number. > > + The second cell is the flags, encoded as the trigger masks from > > + Documentation/devicetree/bindings/interrupts.txt > > +- interrupt-parent : The parent interrupt controller. > > + > > +Optional properties: > > + ti,mux_padX : set the pad register X (1-2) to the correct muxing > for the > > + hardware, if not set will use muxing in OTP. > > + > > +Example: > > + > > +palmas { > > + compatible = "ti,twl6035", "ti,palmas"; > > + reg = <0x48> > > + interrupt-parent = <&intc>; > > + interrupt-controller; > > + #interrupt-cells = <2>; > > + > > + ti,mux-pad1 = <0>; > > + ti,mux-pad2 = <0>; > > + > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + pmic { > > + compatible = "ti,twl6035-pmic", "ti,palmas-pmic"; > > + .... > > + }; > > +} > > diff --git > > a/Documentation/devicetree/bindings/regulator/palmas-pmic.txt > > b/Documentation/devicetree/bindings/regulator/palmas-pmic.txt > > new file mode 100644 > > index 0000000..a0ccdf2 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/regulator/palmas-pmic.txt > > @@ -0,0 +1,65 @@ > > +* palmas regulator IP block devicetree bindings > > + > > +Required properties: > > +- compatible : Should be from the list > > + ti,twl6035-pmic > > + ti,twl6036-pmic > > + ti,twl6037-pmic > > + ti,tps65913-pmic > > + ti,tps65914-pmic > > +and also the generic series names > > + ti,palmas-pmic > > + > > +Optional properties: > > +- ti,ldo6-vibrator : ldo6 is in vibrator mode > > + > > +Optional nodes: > > +- regulators : should contain the constrains and init information > for the > > + regulators. It should contain a subnode per regulator from > the > > + list. > > + For ti,palmas-pmic - smps12, smps123, smps3 depending on > OTP, > > + smps45, smps457, smps7 depending on varient, smps6, > smps[8-10], > > + ldo[1-9], ldoln, ldousb > > + > > + optional chip specific regulator fields :- > > + ti,warm-reset - maintain voltage during warm > reset(boolean) > > + ti,roof-floor - control voltage selection by pin(boolean) > > + ti,sleep-mode - mode to adopt in pmic sleep 0 - off, 1 - > auto, > > + 2 - eco, 3 - forced pwm > > + ti,tstep - slope control 0 - Jump, 1 10mV/us, 2 5mV/us, 3 > 2.5mV/us > > + ti,smps-range - OTP has the wrong range set for the > hardware so override > > + 0 - low range, 1 - high range > > + > > +Example: > > + > > +#include <include/dt-bindings/interrupt-controller/irq.h> > > + > > +pmic { > > + compatible = "ti,twl6035-pmic", "ti,palmas-pmic"; > > + interrupt-parent = <&palmas>; > > + interrupts = <14 IRQ_TYPE_NONE>; > > + interrupt-name = "short-irq"; > > + > > + ti,ldo6-vibrator; > > + > > + regulators { > > + smps12_reg : smps12 { > > + regulator-name = "smps12"; > > + regulator-min-microvolt = < 600000>; > > + regulator-max-microvolt = <1500000>; > > + regulator-always-on; > > + regulator-boot-on; > > + ti,warm-reset; > > + ti,roof-floor; > > + ti,mode-sleep = <0>; > > + ti,tstep = <0>; > > + ti,smps-range = <1>; > > + }; > > + > > + ldo1_reg: ldo1 { > > + regulator-name = "ldo1"; > > + regulator-min-microvolt = <2800000>; > > + regulator-max-microvolt = <2800000>; > > + }; > > + }; > > +}; > > -- > > 1.7.5.4 > > -- > > To unsubscribe from this list: send the line "unsubscribe > > linux-kernel" in the body of a message to majordomo@xxxxxxxxxxxxxxx > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > Please read the FAQ at http://www.tux.org/lkml/ > > -- > Grant Likely, B.Sc, P.Eng. > Secret Lab Technologies, Ltd. -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
