Re: [PATCH v5] LoongArch: vDSO: Wire up getrandom() vDSO implementation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Aug 30, 2024 at 05:05:38PM +0800, Xi Ruoyao wrote:
> On Thu, 2024-08-29 at 16:44 +0200, Jason A. Donenfeld wrote:
> > > So get_vdso_data() + VVAR_LOONGARCH_PAGES_START * PAGE_SIZE should have
> > > already "jumped over" the time-ns vdso data.
> > 
> > Oh good. Thanks for checking. So it sounds like there's just Huacai's
> > set of comments and we're good.
> 
> Both Huacai and I (we've discussed a little off the list) think it seems
> more natural to separate the implementation and the self test into two
> patches.  Do you think it's acceptable?  If not we can live with one
> consolidated patch though.

I'm not such a fan, as wiring up the test makes the whole thing more
"hermetic", but it also doesn't matter to me that much, so if you two
prefer that, that's fine with me and I'll commit it like that.




[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]
  Powered by Linux