Re: [PATCH v7 6/9] platform: cznic: turris-omnia-mcu: Add support for MCU provided TRNG

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 25 Apr 2024 13:04:07 +0300
Andy Shevchenko <andy@xxxxxxxxxx> wrote:

> On Thu, Apr 25, 2024 at 11:34:47AM +0200, Marek Behún wrote:
> > On Wed, 24 Apr 2024 22:47:10 +0300
> > Andy Shevchenko <andy@xxxxxxxxxx> wrote:  
> > > On Wed, Apr 24, 2024 at 08:51:23PM +0200, Marek Behún wrote:  
> 
> ...
> 
> > > For what purpose? I don't see drivers doing that. Are you expecting that
> > > the same IRQ mapping will be reused for something else? Can you elaborate
> > > how? (I can imagine one theoretical / weird case how to achieve that,
> > > but impractical.)  
> > 
> > I do a lot of binding/unbinding of that driver. I was under the
> > impression that all resources should be dropped on driver unbind.
> >   
> > > Besides above, this is asymmetrical call to gpiod_to_irq(). If we really care
> > > about this, it should be provided by GPIO library.  
> > 
> > Something like the following?  
> 
> Not needed. IRQ mappings are per domain, and GPIO chip has its own associated
> with the respective lifetime, AFAIU when you remove the GPIO chip, all mappings
> will be disposed (as I pointed out in previous mail).
> 

OMG you are right :) of course. OK, I shall drop this.

Marek





[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]
  Powered by Linux