On Wed, 24 Apr 2024 21:33:44 +0300
Andy Shevchenko <andy@xxxxxxxxxx> wrote:
> On Wed, Apr 24, 2024 at 07:38:05PM +0200, Marek Behún wrote:
> > Add support for true random number generator provided by the MCU.
> > New Omnia boards come without the Atmel SHA204-A chip. Instead the
> > crypto functionality is provided by new microcontroller, which has
> > a TRNG peripheral.
>
> ...
>
> > +static void omnia_irq_mapping_drop(void *res)
> > +{
> > + irq_dispose_mapping((unsigned int)(unsigned long)res);
> > +}
>
> Leftover?
What do you mean? I dropped the devm-helpers.h changes, now I do
devm_add_action_or_reset() manually, with this function as the action.
> > +int omnia_mcu_register_trng(struct omnia_mcu *mcu)
> > +{
> > + struct device *dev = &mcu->client->dev;
> > + u8 irq_idx, dummy;
> > + int irq, err;
> > +
> > + if (!(mcu->features & FEAT_TRNG))
> > + return 0;
> > +
> > + irq_idx = omnia_int_to_gpio_idx[__bf_shf(INT_TRNG)];
> > + irq = gpiod_to_irq(gpiochip_get_desc(&mcu->gc, irq_idx));
> > + if (irq < 0)
> > + return dev_err_probe(dev, irq, "Cannot get TRNG IRQ\n");
>
> > + err = devm_add_action_or_reset(dev, omnia_irq_mapping_drop,
> > + (void *)(unsigned long)irq);
> > + if (err)
> > + return err;
>
> Are you sure it's correct now?
Yes, why wouldn't it?
