On Sat, Aug 19, 2023 at 09:33:18AM +0200, Ard Biesheuvel wrote: > > No, that otx2_write128() routine looks buggy, actually, The ! at the > end means writeback, and so the register holding addr will be > modified, which is not reflect in the asm constraints. It also lacks a > barrier. OK. But at least having a helper called write128 looks a lot cleaner than just having unexplained assembly in the code. Cheers, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
