On Fri, Aug 18, 2023 at 12:21:02PM +0200, Ard Biesheuvel wrote: > > IIRC there have been other cases (ThunderX?) where 128 bit MMIO > accessors were needed for some peripheral, but common arm64 helpers > were rejected on the basis that this atomic behavior is not > architectural. > > Obviously, using inline asm in the driver is not the right way either, > so perhaps we should consider introducing some common infrastructure > anyway, including some expectation management about their guarantees. The ones in drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h look better. So perhaps copy them into hisilicon? Cheers, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
