On Tue, Jul 28, 2020 at 08:46:42PM +0300, Ard Biesheuvel wrote: > > > Yes we could add a flag for it. However, for the two users that > > I'm looking at right now (algif_skcipher and sunrpc) this is not > > required. For algif_skcipher it'll simply fall back to the current > > behaviour if chaining is not supported, while sunrpc would only > > use chaining with cts where it is always supported. > > Ok, now I'm confused again: if falling back to the current behavior is > acceptable for algif_skcipher, why do we need all these changes? The current behaviour isn't quite the right phrase. What happens now is that algif_skcipher will try to chain everything which would obviously fail with such a driver. With the patch-set it won't try to chain and will instead return -EINVAL. Cheers, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
