On Tue, 28 Jul 2020 at 20:22, Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote: > > On Tue, Jul 28, 2020 at 10:15:12AM -0700, Eric Biggers wrote: > > > > Shouldn't chaining be disabled by default? This is inviting bugs where drivers > > don't implement chaining, but leave final_chunksize unset (0) which apparently > > indicates that chaining is supported. > > I've gone through everything and the majority of algorithms do > support chaining so I think defaulting to on makes more sense. > > For now we have some algorithms that can be chained but the drivers > do not allow it, this is not something that I'd like to see in > new drivers. > So how does one allocate a tfm that supports chaining if their use case requires it? Having different implementations of the same algo where one does support it while the other one doesn't means we will need some flag to request this at alloc time. > Cheers, > -- > Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> > Home Page: http://gondor.apana.org.au/~herbert/ > PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
