On Tue, 28 Jul 2020 at 20:30, Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote: > > On Tue, Jul 28, 2020 at 08:26:38PM +0300, Ard Biesheuvel wrote: > > > > So how does one allocate a tfm that supports chaining if their use > > case requires it? Having different implementations of the same algo > > where one does support it while the other one doesn't means we will > > need some flag to request this at alloc time. > > Yes we could add a flag for it. However, for the two users that > I'm looking at right now (algif_skcipher and sunrpc) this is not > required. For algif_skcipher it'll simply fall back to the current > behaviour if chaining is not supported, while sunrpc would only > use chaining with cts where it is always supported. > Ok, now I'm confused again: if falling back to the current behavior is acceptable for algif_skcipher, why do we need all these changes? > Cheers, > -- > Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> > Home Page: http://gondor.apana.org.au/~herbert/ > PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt