> -----Original Message----- > From: linux-crypto-owner@xxxxxxxxxxxxxxx <linux-crypto-owner@xxxxxxxxxxxxxxx> On Behalf Of Herbert Xu > Sent: Friday, July 19, 2019 4:58 PM > To: Pascal Van Leeuwen <pvanleeuwen@xxxxxxxxxxxxxx> > Cc: linux-crypto@xxxxxxxxxxxxxxx; David S. Miller <davem@xxxxxxxxxxxxx> > Subject: Re: generic ahash question > > On Fri, Jul 19, 2019 at 02:41:03PM +0000, Pascal Van Leeuwen wrote: > > > > So I'm guessing there must be some flags that I can set to indicate I'm not supporting seperate > > init/update/final calls so that testmgr skips those specific tests? Which flag(s) do I need to set? > > All implementations must support all of these calls. If your > hardware cannot produce non-finalised output, then what you need > to do is use a fallback for init/update and then implement final, > finup and digest. If your hardware can't even accept non-finalised > input, then you will need to use a fallback for everything but > digest. > Thanks, that was sort of the answer I was fearing :-) So I guess I'll opt for door number 3 for now: don't advertise the algorithm unless someone comes with a very solid use case for accelerating it ... > Since IPsec uses the digest call it would still be able to benefit. > For IPsec I don't need the standalone MACs anyway since I also advertise the combined AEAD constructs which are far more efficient to use on our HW. > Cheers, > -- > Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> > Home Page: http://gondor.apana.org.au/~herbert/ > PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt Regards, Pascal van Leeuwen Silicon IP Architect, Multi-Protocol Engines @ Verimatrix www.insidesecure.com
