On 7/19/2019 2:58 AM, Iuliana Prodan wrote: > Check the return value of the hardware registration for caam_rng and free > resources in case of failure. > > Fixes: 6e4e603a9 ("crypto: caam - Dynamic memory allocation for caam_rng_ctx object") This should be: Fixes: e24f7c9e87d4 ("crypto: caam - hwrng support") since there are resources leaked (like DMA mapped buffers) due to not checking the return code of hwrng_register() even in the initial caamrng commit. This doesn't have much practical value, since we haven't seen this failure in practice and we don't intend fixing previous kernel releases. Horia