Re: [PATCH 1/2] net: fastopen: make key handling more robust against future changes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH 1/2] net: fastopen: make key handling more robust against future changes
From: Eric Dumazet <edumazet@xxxxxxxxxx>
Date: Tue, 18 Jun 2019 11:19:11 -0700
Cc: Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx>, netdev <netdev@xxxxxxxxxxxxxxx>, "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" <linux-crypto@xxxxxxxxxxxxxxx>, Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>, David Miller <davem@xxxxxxxxxxxxx>, Alexey Kuznetsov <kuznet@xxxxxxxxxxxxx>, Hideaki YOSHIFUJI <yoshfuji@xxxxxxxxxxxxxx>, Jason Baron <jbaron@xxxxxxxxxx>, Christoph Paasch <cpaasch@xxxxxxxxx>, David Laight <David.Laight@xxxxxxxxxx>, Yuchung Cheng <ycheng@xxxxxxxxxx>
In-reply-to: <20190618181804.GJ184520@gmail.com>
References: <20190618093207.13436-1-ard.biesheuvel@linaro.org> <20190618093207.13436-2-ard.biesheuvel@linaro.org> <CANn89iJuTq36KMf1madQH08g6K0a-Uj-PDH80ao9zuEw+WNcZg@mail.gmail.com> <CAKv+Gu894bEEzpKNDTaNiiNJTFoUTYQuFjBBm-ezdkrzW5fyNQ@mail.gmail.com> <CANn89i+X7YQ6DueDQAusA+1S5Kmo75OwzO+eYRZe_nR8=YWjuQ@mail.gmail.com> <20190618181804.GJ184520@gmail.com>

On Tue, Jun 18, 2019 at 11:18 AM Eric Biggers <ebiggers@xxxxxxxxxx> wrote:

> The length parameter makes no sense if it's not checked, though.  Either it
> should exist and be checked, or it should be removed and the length should be
> implicitly TCP_FASTOPEN_KEY_LENGTH.

Sure, please send a patch.

References:
- [PATCH 0/2] net: fastopen: follow-up tweaks for SipHash switch
  - From: Ard Biesheuvel
- [PATCH 1/2] net: fastopen: make key handling more robust against future changes
  - From: Ard Biesheuvel
- Re: [PATCH 1/2] net: fastopen: make key handling more robust against future changes
  - From: Eric Dumazet
- Re: [PATCH 1/2] net: fastopen: make key handling more robust against future changes
  - From: Ard Biesheuvel
- Re: [PATCH 1/2] net: fastopen: make key handling more robust against future changes
  - From: Eric Dumazet
- Re: [PATCH 1/2] net: fastopen: make key handling more robust against future changes
  - From: Eric Biggers

Prev by Date: Re: [PATCH 1/2] net: fastopen: make key handling more robust against future changes
Next by Date: Re: [PATCH 2/2] net: fastopen: use endianness agnostic representation of the cookie
Previous by thread: Re: [PATCH 1/2] net: fastopen: make key handling more robust against future changes
Next by thread: [PATCH 2/2] net: fastopen: use endianness agnostic representation of the cookie
Index(es):
- Date
- Thread

[Index of Archives] [Kernel] [Gnu Classpath] [Gnu Crypto] [DM Crypt] [Netfilter] [Bugtraq]